← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~lp-markusschade/cloud-init:hetznercloud_ds into cloud-init:master

 

Hi Scott,

thank you for your review. 

We have refactored it using EphemeralIPv4Network and are working to add some unit tests for the DS as well.

Also most of your other comments (not decoding userdata, unifying the URL, etc) are also addressed. 

-- 
https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/338439
Your team cloud-init commiters is requested to review the proposed merge of ~lp-markusschade/cloud-init:hetznercloud_ds into cloud-init:master.


References