cloud-init-dev team mailing list archive
-
cloud-init-dev team
-
Mailing list archive
-
Message #04346
Re: [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/snap.yaml b/tests/cloud_tests/testcases/modules/snap.yaml
> new file mode 100644
> index 0000000..e520415
> --- /dev/null
> +++ b/tests/cloud_tests/testcases/modules/snap.yaml
> @@ -0,0 +1,21 @@
> +#
> +# Install snappy
> +#
> +required_features:
> + - snap
> +cloud_config: |
> + #cloud-config
> + package_update: true
> + snap:
> + squashfuse_in_container: true
> + commands:
> + - snap install hello-world
> +collect_scripts:
> + snaplist: |
> + #!/bin/bash
> + snap list
> + instance-data.json: |
> + #!/bin/sh
> + cat /run/cloud-init/instance-data.json
the fix for one-ssh-per-file is to stop doing one-ssh-per-file :) If this makes us more motivated to do something smarter than thats a good thing in my mind. We shouldn't make our tests less useful because our harness is silly.
so yes, i'd prefer it in base.
> +
> +# vi: ts=4 expandtab
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:feature/snap-module into cloud-init:master.