cloud-init-dev team mailing list archive

[Chad Smith <chad.smith@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/tests/unittests/test_ds_identify.py b/tests/unittests/test_ds_identify.py
> index 9c5628e..ed654c4 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -502,6 +507,12 @@ VALID_CFG = {
>          'policy_dmi': POLICY_FOUND_ONLY,
>          'policy_no_dmi': POLICY_FOUND_ONLY,
>      },
> +    'OpenStack-OpenTelekom': {
> +        # OTC gen1 (Xen) hosts use OpenStack datasource, LP: #1756471
> +        'ds': 'OpenStack',
> +        'files': {P_CHASSIS_ASSET_TAG: 'OpenTelekomCloud\n'},
> +        'mocks': [MOCK_VIRT_IS_XEN],

you are mocking XEN in the test and the test passes on either XEN or KVM, should ds-identify tool specifically limit a positive match to XEN too?

> +    },
>      'OVF-seed': {
>          'ds': 'OVF',
>          'files': {


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341851
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/lp-1756471-open-telekom into cloud-init:master.