cloud-init-dev team mailing list archive

[Scott Moser <ssmoser2+ubuntu@xxxxxxxxx>]

Scott Moser has proposed merging ~smoser/cloud-init:fix/ec2-invert-exception_cb-logic into cloud-init:master.

Commit message:
ec2: Adjust ec2 datasource after exception_cb change.

The recent change to exception_cb missed this caller.
The result was a slow test.

Requested reviews:
  cloud-init commiters (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341998
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/ec2-invert-exception_cb-logic into cloud-init:master.

diff --git a/cloudinit/ec2_utils.py b/cloudinit/ec2_utils.py
index d6c61e4..dc3f0fc 100644
--- a/cloudinit/ec2_utils.py
+++ b/cloudinit/ec2_utils.py
@@ -135,10 +135,8 @@ class MetadataMaterializer(object):
 
 
 def _skip_retry_on_codes(status_codes, _request_args, cause):
-    """Returns if a request should retry based on a given set of codes that
-    case retrying to be stopped/skipped.
-    """
-    return cause.code in status_codes
+    """Returns False if cause.code is in status_codes."""
+    return cause.code not in status_codes
 
 
 def get_instance_userdata(api_version='latest',