cloud-init-dev team mailing list archive

[Ryan Harper <ryan.harper@xxxxxxxxxxxxx>]

Fix your commit message, you're paying attention to:

# W0612(unused-variable)

Not 

# W0621(redefined-outer-name)

Diff comments:

> diff --git a/cloudinit/analyze/dump.py b/cloudinit/analyze/dump.py
> index b071aa1..1bb16da 100644
> --- a/cloudinit/analyze/dump.py
> +++ b/cloudinit/analyze/dump.py
> @@ -112,7 +112,7 @@ def parse_ci_logline(line):
>              return None
>          event_description = stage_to_description[event_name]
>      else:
> -        (pymodloglvl, event_type, event_name) = eventstr.split()[0:3]
> +        (_pymodloglvl, _event_type, event_name) = eventstr.split()[0:3]

This doesn't seem related to W0621?

>          event_description = eventstr.split(event_name)[1].strip()
>  
>      event = {


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343469
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into cloud-init:master.