cloud-init-dev team mailing list archive

[Mike Gerdts <mike.gerdts@xxxxxxxxxx>]

Review: Approve

I've approved this, but do think a comment update to explain None will reduce future confusion.

Diff comments:

> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 8005454..7a54051 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -335,7 +335,7 @@ def interface_has_own_mac(ifname, strict=False):
>      assign_type = read_sys_net_int(ifname, "addr_assign_type")
>      if strict and assign_type is None:
>          raise ValueError("%s had no addr_assign_type.")
> -    return assign_type in (0, 1, 3)
> +    return assign_type in (0, 1, 3, None)

An update to the comment above explaining None would be helpful.

>  
>  
>  def _get_current_rename_info(check_downable=True):


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343739
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/smartos-container-nics-have-own-mac into cloud-init:master.