cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master

To: Scott Moser <ssmoser2+ubuntu@xxxxxxxxx>
From: Scott Moser <ssmoser2+ubuntu@xxxxxxxxx>
Date: Tue, 01 May 2018 20:19:50 -0000
In-reply-to: <152414444117.14082.9001395248822905723.launchpad@ackee.canonical.com>
Reply-to: mp+343610@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I'm not sure what I think about this.
I like that it will now catch errors that were previously swallowed...
I ran into this when I added some schema changes and failed to add
skipUnlessJsonSchema and there were no failures... it wasnt skipped
and there were no failures, just passed as the import error was ignored.

So I like that.

What I do not like is that in reality since we support running without
jsonschema, cloud-init can never actually *use* strict=True.

hm..
Thoughts?

-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343610
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master.

References

[Merge] ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master
From: Scott Moser, 2018-04-19