← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~chad.smith/cloud-init:cleanup/sync-pycodestyle into cloud-init:master

 


Diff comments:

> diff --git a/tox.ini b/tox.ini
> index 818ade3..268d230 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -10,9 +10,9 @@ setenv =
>  [testenv:flake8]
>  basepython = python3
>  deps =
> -    pycodestyle==2.3.1
> -    pyflakes==1.5.0
> -    flake8==3.3.0
> +    pycodestyle==2.4.0
> +    pyflakes==1.6.0
> +    flake8==2.5.4

I think this should be 3.5.0 as if we go with your 2.5.4 we would be going backwards. See https://pypi.org/project/flake8/

>      hacking==0.13.0
>  commands = {envpython} -m flake8 {posargs:cloudinit/ tests/ tools/}
>  


-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/344976
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:cleanup/sync-pycodestyle into cloud-init:master.


References