cloud-init-dev team mailing list archive

[Ryan Harper <ryan.harper@xxxxxxxxxxxxx>]

Diff comments:

> diff --git a/tools/run-container b/tools/run-container
> index 499e85b..6dedb75 100755
> --- a/tools/run-container
> +++ b/tools/run-container
> @@ -529,8 +529,8 @@ main() {
>              build_srcpkg="./packages/brpm $distflag --srpm"
>              pkg_ext=".rpm";;
>      esac
> -    if [ -n "$source_package" ]; then
> -        [ -n "$build_pkg" ] || {

Was this a subtle bug that you fixed here too? source_package + build_package?

> +    if [ "$srcpackage" = "true" ]; then
> +        [ -n "$build_srcpkg" ] || {
>              error "Unknown package command for $OS_NAME"
>              return 1
>          }


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/348677
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/run-container-no-artifacts into cloud-init:master.