← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

 

Is it worth leaving a reference to this LP: # in the both the systemd unit file and with the genkeytypes?

ssh_genkeytypes: null  # LP: #XXXXXXXX




Diff comments:

> diff --git a/config/cloud.cfg.tmpl b/config/cloud.cfg.tmpl
> index 5619de3..1fef133 100644
> --- a/config/cloud.cfg.tmpl
> +++ b/config/cloud.cfg.tmpl
> @@ -24,8 +24,6 @@ disable_root: true
>  {% if variant in ["centos", "fedora", "rhel"] %}
>  mount_default_fields: [~, ~, 'auto', 'defaults,nofail', '0', '2']
>  resize_rootfs_tmp: /dev
> -ssh_deletekeys:   0
> -ssh_genkeytypes:  ~

without setting this, won't this mean ssh_genkeytypes defaults to the 4 types we normally generate?  Doesn't this conflict with sshd-keygen service?

Shouldn't we leave this key in but set to null?

>  ssh_pwauth:   0
>  
>  {% endif %}


-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/349359
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master.


References