← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:bug/1784699-netplan-macaddress-on-bond into cloud-init:master

 

On Fri, Aug 3, 2018 at 1:28 PM Scott Moser <ssmoser2+ubuntu@xxxxxxxxx> wrote:
>
> @Ryan,
> I added the handling for bridges as well.
> It seems right, but kind of scary in that it will change behavior.
>
> thoughts?

MAAS team filed a bug that they don't normally send the bridge mac and
complained that netplan didn't automatically select on of the bridge interfaces

The bond mac is just as "wrong" in a sense that the bond itself will change its
mac as needed anyhow, for example, active-backup mode where the active
slave MAC is what is used, and if that drops, then the bond's mac will
change to the other active slave.

Our v1 eni renderer would render mac_address for bridges or bonds if
present in the bridge or bond config.

For users of netplan, they've not been assigning a mac_address to the
bridge or bond up till now and get a random one;  The case where this
would have showed up would be an environment where DHCP was handled
by-mac;  users likely would have already seen issues where the
bond/bridge interface didn't get the "correct" ip address due to
random mac assignment by networkd.


>
> --
> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/352033
> Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1784699-netplan-macaddress-on-bond into cloud-init:master.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cloud-init-dev
> Post to     : cloud-init-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cloud-init-dev
> More help   : https://help.launchpad.net/ListHelp

-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/352033
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1784699-netplan-macaddress-on-bond into cloud-init:master.


References