cloud-init-dev team mailing list archive

[Scott Moser <ssmoser2+ubuntu@xxxxxxxxx>]

Scott Moser has proposed merging ~smoser/cloud-init:fix/disable-lxd-cosmic-tests-1795036 into cloud-init:master.

Commit message:
tests: disable lxd tests on cosmic

Skip lxd tests on cosmic for two reasons:
a.) LP: #1795036 - 'lxd init' fails on cosmic kernel.
b.) apt install lxd installs via snap which can be slow
    as that will download core snap and lxd.

Requested reviews:
  cloud-init commiters (cloud-init-dev)
Related bugs:
  Bug #1795036 in linux (Ubuntu): "iptables --list --numeric fails on -virtual kernel"
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1795036

For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/355867

see commit message
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/disable-lxd-cosmic-tests-1795036 into cloud-init:master.

diff --git a/tests/cloud_tests/testcases/modules/lxd_bridge.py b/tests/cloud_tests/testcases/modules/lxd_bridge.py
index f6011de..8697ae9 100644
--- a/tests/cloud_tests/testcases/modules/lxd_bridge.py
+++ b/tests/cloud_tests/testcases/modules/lxd_bridge.py
@@ -7,6 +7,15 @@ from tests.cloud_tests.testcases import base
 class TestLxdBridge(base.CloudTestCase):
     """Test LXD module."""
 
+    def setUp(self):
+        """Skip on cosmic for two reasons:
+        a.) LP: #1795036 - 'lxd init' fails on cosmic kernel.
+        b.) apt install lxd installs via snap which can be slow
+            as that will download core snap and lxd."""
+        if self.os_name == "cosmic":
+            raise self.skipTest('Skipping test on cosmic (LP: #1795036).')
+        return base.CloudTestCase.setUp(self)
+
     def test_lxd(self):
         """Test lxd installed."""
         out = self.get_data_file('lxd')
diff --git a/tests/cloud_tests/testcases/modules/lxd_dir.py b/tests/cloud_tests/testcases/modules/lxd_dir.py
index 26a3db3..8bd8c6e 100644
--- a/tests/cloud_tests/testcases/modules/lxd_dir.py
+++ b/tests/cloud_tests/testcases/modules/lxd_dir.py
@@ -7,6 +7,15 @@ from tests.cloud_tests.testcases import base
 class TestLxdDir(base.CloudTestCase):
     """Test LXD module."""
 
+    def setUp(self):
+        """Skip on cosmic for two reasons:
+        a.) LP: #1795036 - 'lxd init' fails on cosmic kernel.
+        b.) apt install lxd installs via snap which can be slow
+            as that will download core snap and lxd."""
+        if self.os_name == "cosmic":
+            raise self.skipTest('Skipping test on cosmic (LP: #1795036).')
+        return base.CloudTestCase.setUp(self)
+
     def test_lxd(self):
         """Test lxd installed."""
         out = self.get_data_file('lxd')