cloud-init-dev team mailing list archive
-
cloud-init-dev team
-
Mailing list archive
-
Message #05715
[Merge] ~tomerc/cloud-init:patch-replace-nameserver-with-nameservers into cloud-init:master
Tomer Cohen has proposed merging ~tomerc/cloud-init:patch-replace-nameserver-with-nameservers into cloud-init:master.
Commit message:
Change dns_nameserver property to dns_nameservers
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~tomerc/cloud-init/+git/cloud-init/+merge/357919
According to the examples in the page, DNS should be defined using the dns_nameservers. Specifying dns_nameserver is undefined.
https://cloudinit.readthedocs.io/en/latest/topics/network-config-format-v1.html#subnet-ip
--
Your team cloud-init commiters is requested to review the proposed merge of ~tomerc/cloud-init:patch-replace-nameserver-with-nameservers into cloud-init:master.
diff --git a/doc/rtd/topics/network-config-format-v1.rst b/doc/rtd/topics/network-config-format-v1.rst
index 8352000..dfbde51 100644
--- a/doc/rtd/topics/network-config-format-v1.rst
+++ b/doc/rtd/topics/network-config-format-v1.rst
@@ -384,7 +384,7 @@ Valid keys for ``subnets`` include the following:
- ``address``: IPv4 or IPv6 address. It may include CIDR netmask notation.
- ``netmask``: IPv4 subnet mask in dotted format or CIDR notation.
- ``gateway``: IPv4 address of the default gateway for this subnet.
-- ``dns_nameserver``: Specify a list of IPv4 dns server IPs to end up in
+- ``dns_nameservers``: Specify a list of IPv4 dns server IPs to end up in
resolv.conf.
- ``dns_search``: Specify a list of search paths to be included in
resolv.conf.
Follow ups