cloud-init-dev team mailing list archive

[Igor Galić <i.galic@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Looks pretty okay so far, except for…

Diff comments:

> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index ad98a59..c1f9c13 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -692,6 +716,9 @@ class EphemeralIPv4Network(object):
>          for cmd in self.cleanup_cmds:
>              util.subp(cmd, capture=True)
>  
> +    def _connectivity_ceck():
> +        """Perform connectivity check using connectivity_url"""
> +

this needs to go

>      def _delete_address(self, address, prefix):
>          """Perform the ip command to remove the specified address."""
>          util.subp(
> diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py
> index bdc5799..0db991d 100644
> --- a/cloudinit/net/dhcp.py
> +++ b/cloudinit/net/dhcp.py
> @@ -86,6 +95,8 @@ class EphemeralDHCPv4(object):
>          kwargs = dict([(k, self.lease.get(v)) for k, v in nmap.items()])
>          if not kwargs['broadcast']:
>              kwargs['broadcast'] = bcip(kwargs['prefix_or_mask'], kwargs['ip'])
> +        if self.connectivity_url:
> +            kwargs['connectivity_url'] = self.connectivity_url

should we keep this?

>          ephipv4 = EphemeralIPv4Network(**kwargs)
>          ephipv4.__enter__()
>          self._ephipv4 = ephipv4


-- 
https://code.launchpad.net/~i.galic/cloud-init/+git/cloud-init/+merge/358876
Your team cloud-init commiters is requested to review the proposed merge of ~i.galic/cloud-init:feax/ephemeral_connectivity into cloud-init:master.