cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~i.galic/cloud-init:feax/ephemeral_connectivity into cloud-init:master

To: Igor Galić <i.galic@xxxxxxxxxxxxxx>
From: Chad Smith <chad.smith@xxxxxxxxxxxxx>
Date: Mon, 19 Nov 2018 23:19:37 -0000
In-reply-to: <154231563821.5933.8224776626074917372.launchpad@ackee.canonical.com>
Reply-to: mp+358876@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

The integration tests also voted failure on your branch because you didn't import UrlError in net/__init__.py. running tox locally on your system would have shown this if you have unit tests on the new function that was added.
-- 
https://code.launchpad.net/~i.galic/cloud-init/+git/cloud-init/+merge/358876
Your team cloud-init commiters is requested to review the proposed merge of ~i.galic/cloud-init:feax/ephemeral_connectivity into cloud-init:master.

References

[Merge] ~i.galic/cloud-init:feax/ephemeral_connectivity into cloud-init:master
From: Igor Galić, 2018-11-15