← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~legovini/cloud-init:fix/tox-flake8 into cloud-init:master

 

Paride Legovini has proposed merging ~legovini/cloud-init:fix/tox-flake8 into cloud-init:master.

Commit message:
flake8: use ==/!= to compare str, bytes, and int literals

Requested reviews:
  cloud-init commiters (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~legovini/cloud-init/+git/cloud-init/+merge/362293
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~legovini/cloud-init:fix/tox-flake8 into cloud-init:master.
diff --git a/cloudinit/config/cc_rh_subscription.py b/cloudinit/config/cc_rh_subscription.py
index edee01e..28c79b8 100644
--- a/cloudinit/config/cc_rh_subscription.py
+++ b/cloudinit/config/cc_rh_subscription.py
@@ -249,14 +249,14 @@ class SubscriptionManager(object):
         except util.ProcessExecutionError as e:
             if e.stdout.rstrip() != '':
                 for line in e.stdout.split("\n"):
-                    if line is not '':
+                    if line != '':
                         self.log_warn(line)
             else:
                 self.log_warn("Setting the service level failed with: "
                               "{0}".format(e.stderr.strip()))
             return False
         for line in return_out.split("\n"):
-            if line is not "":
+            if line != "":
                 self.log.debug(line)
         return True
 
@@ -268,7 +268,7 @@ class SubscriptionManager(object):
             self.log_warn("Auto-attach failed with: {0}".format(e))
             return False
         for line in return_out.split("\n"):
-            if line is not "":
+            if line != "":
                 self.log.debug(line)
         return True
 

Follow ups