← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~raharper/cloud-init:fix/ds_update_events into cloud-init:master

 

The proposal to merge ~raharper/cloud-init:fix/ds_update_events into cloud-init:master has been updated.

Commit message changed to:

DataSource: use class prop for subclass override of update_events

Subclasses of DataSource, like DataSourceAzure would update
the .update_events attribute of the base-class; this value
is propagated to any future subclass that gets instantiated.
Therefore cloud-init would *leak* these additional update_events
into subclasses which do not use them.

Convert the class attribute into a property and allow subclasses
to override the property to append/modify the attribute but only
for the subclass.

LP: #1819913

For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/364403
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/ds_update_events into cloud-init:master.


References