← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

 


Diff comments:

> diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py
> index 4d19f56..91046b5 100644
> --- a/cloudinit/net/network_state.py
> +++ b/cloudinit/net/network_state.py
> @@ -707,6 +707,13 @@ class NetworkStateInterpreter(object):
>              item_params = dict((key, value) for (key, value) in
>                                 item_cfg.items() if key not in
>                                 NETWORK_V2_KEY_FILTER)
> +            if 'gratuitious-arp' in item_params['parameters']:
> +                params = item_params['parameters']

This might as well move out of the if, so save the duplicate lookup the line above.

> +                old_key = 'gratuitious-arp'
> +                new_key = 'gratuitous-arp'
> +                params[new_key] = copy.copy(params[old_key])
> +                del params[old_key]
> +
>              v1_cmd = {
>                  'type': cmd_type,
>                  'name': item_name,


-- 
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/366935
Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master.


References