← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master


Your successful log path would not even include the final location for the file, which is ultimately the useful thing (except in the write-failed case, which is probably rare).

I think I'd prefer logging with a message that included the target file (filename), not just the temporary file name.  And hopefully a way to differentiate in the log message between atomic_helpers.write_file and write_file.

Your team cloud-init Commiters is requested to review the proposed merge of ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.