← Back to team overview

compiz team mailing list archive

Re: [Bug 684019] Re: 0.9.2 «put» plugin moves any window only to second viewport

 

On Sat, Jul 2, 2011 at 10:08 PM, chca <684019@xxxxxxxxxxxxxxxxxx> wrote:
> Okay, this bug annoyed me very much, so I identified it in the source
> code. What really happened: Whenever you first move a window to a
> different viewport, the target viewport number is appended to a list.
> When you do it again, the old entry is not removed or updated; instead a
> new "viewport" entry is added (which also is a small memory leak).
> Afterwards, only the first "viewport" entry in the list is ever read on
> moving a window, so all subsequent windows will be sent to the viewport
> to which the first window was moved (it can also be the first, third,
> fourth or any other one).
>

Thanks for the patch, but I don't quite understand it. Are you saying
that the "viewport" option is being appended to "options" every single
time and this "options" vector is persistent among calls to
::toViewport ? Since that's definitely wrong and is a bug in core if
that's happening.

> A patch proposal is attached.
>
> ** Patch added: "fix for this issue"
>   https://bugs.launchpad.net/ubuntu/+source/compiz-fusion-plugins-main/+bug/684019/+attachment/2187914/+files/0001-bug-fix-overwrite-viewport-option-parameter-instead-.patch
>
> --
> You received this bug notification because you are a member of compiz
> packagers, which is subscribed to compiz-fusion-plugins-main in Ubuntu.
> https://bugs.launchpad.net/bugs/684019
>
> Title:
>  0.9.2 «put» plugin moves any window only to second viewport
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/compiz-fusion-plugins-main/+bug/684019/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~compiz
> Post to     : compiz@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~compiz
> More help   : https://help.launchpad.net/ListHelp
>


-- 
Sam Spilsbury

-- 
You received this bug notification because you are a member of compiz
packagers, which is subscribed to compiz-fusion-plugins-main in Ubuntu.
https://bugs.launchpad.net/bugs/684019

Title:
  0.9.2 «put» plugin moves any window only to second viewport

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/compiz-fusion-plugins-main/+bug/684019/+subscriptions


Follow ups

References