← Back to team overview

compiz team mailing list archive

[Bug 1013171] Re: Many package hooks not ported to python3

 

compiz needs the same one-line patch as the last few, and it has another
issue, at least on my machine.  It appears the 'source_compiz.py' hook
needs this import:

  from apport.hookutils import *

And I've added that in my patch.  Without it 'ubuntu-bug compiz' throws
an exception, saying the function 'command_output' is not defined.

  ERROR: hook /usr/share/apport/package-hooks//source_compiz.py crashed:
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/apport/report.py", line 799, in add_hooks_info
      symb['add_info'](self, ui)
    File "/usr/share/apport/package-hooks//source_compiz.py", line 18, in add_info
      report['CompizPlugins'] = command_output(['gconftool-2',
  NameError: global name 'command_output' is not defined

Some apport hooks have the import statement above.  Some have just
'import apport.hookutils'.  Only the former fixed this on my system.
The latter seems to work fine for other packages, but not here.  Maybe
I'm misssing something; I didn't explore this any further.   (Nor did I
try to fix bug 777221 while I was in there. :)

Thanks.


** Patch added: "python3 patch for compiz's apport hook.  also adds an 'import' that seems needed."
   https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/1013171/+attachment/3207409/+files/compiz.patch

** Changed in: compiz (Ubuntu Quantal)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of compiz
packagers, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1013171

Title:
  Many package hooks not ported to python3

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1013171/+subscriptions