configglue team mailing list archive

[Natalia Bidart <natalia.bidart@xxxxxxxxxxxxx>]

Natalia Bidart has proposed merging lp:~nataliabidart/configglue/missing-openid-schema into lp:configglue.

Commit message:
- Added missing openid_email_whitelist_regexp_list option to the openid schema.

Requested reviews:
  Configglue developers (configglue)

For more details, see:
https://code.launchpad.net/~nataliabidart/configglue/missing-openid-schema/+merge/166588
-- 
https://code.launchpad.net/~nataliabidart/configglue/missing-openid-schema/+merge/166588
Your team Configglue developers is requested to review the proposed merge of lp:~nataliabidart/configglue/missing-openid-schema into lp:configglue.

=== modified file 'configglue/contrib/schema/django_openid_auth.py'
--- configglue/contrib/schema/django_openid_auth.py	2013-05-03 21:26:39 +0000
+++ configglue/contrib/schema/django_openid_auth.py	2013-05-30 19:44:28 +0000
@@ -46,3 +46,5 @@
         openid_trust_root = StringOption()
         openid_sso_server_url = StringOption(
             null=True)
+        openid_email_whitelist_regexp_list = ListOption(
+            item=StringOption())

=== modified file 'configglue/tests/test_contrib_schema.py'
--- configglue/tests/test_contrib_schema.py	2013-05-03 21:41:38 +0000
+++ configglue/tests/test_contrib_schema.py	2013-05-30 19:44:28 +0000
@@ -9,5 +9,11 @@
     def test_openid_launchpad_teams_required_option(self):
         schema = DjangoOpenIdAuthSchema()
         option = schema.openid.openid_launchpad_teams_required
-        self.assertTrue(isinstance(option, ListOption))
-        self.assertTrue(isinstance(option.item, StringOption))
+        self.assertIsInstance(option, ListOption)
+        self.assertIsInstance(option.item, StringOption)
+
+    def test_openid_email_whitelist_regexp_list_option(self):
+        schema = DjangoOpenIdAuthSchema()
+        option = schema.openid.openid_email_whitelist_regexp_list
+        self.assertIsInstance(option, ListOption)
+        self.assertIsInstance(option.item, StringOption)