← Back to team overview

configglue team mailing list archive

Re: [Merge] lp:~ricardokirkner/configglue/1196754-non-utf8-locale into lp:configglue

 

> This looks like a reasonable change, but one question: why not use
> codecs.open() instead of open() in both the Python 2 and Python 3 case?  I
> just tried it locally by changing the open_file() definition to remove the if-
> test and use codecs.open() unconditionally.  It still worked (as I would
> expect).

nice idea. fixed
-- 
https://code.launchpad.net/~ricardokirkner/configglue/1196754-non-utf8-locale/+merge/173236
Your team Configglue developers is requested to review the proposed merge of lp:~ricardokirkner/configglue/1196754-non-utf8-locale into lp:configglue.


References