credativ team mailing list archive
-
credativ team
-
Mailing list archive
-
Message #00044
Re: [Merge] lp:~credativ/openobject-addons/fix-chart-of-accounts into lp:openobject-addons
Hi Craig Gowing,
i've merged your branch, but before i made few cleaning:
* the function _get_fiscalyear should have been using the existing function find() of account.fiscalyear, to avoid code redudancy
* the change in the sql query to ensure having the starting period in periods[0] and the ending period as periods[1] should have been done by replacing the sql operator UNION with UNION ALL (that preserves the order). It's cleaner that way.
Anyway, thanks for the contribution
--
https://code.launchpad.net/~credativ/openobject-addons/fix-chart-of-accounts/+merge/79540
Your team Credativ is subscribed to branch lp:~credativ/openobject-addons/fix-chart-of-accounts.
References