← Back to team overview

credativ team mailing list archive

Re: [Merge] lp:~credativ/account-banking/trunk-refresh into lp:account-banking/5.0

 

On 10/11/11 13:09, Pieter J. Kersten (EduSense BV) wrote:
> Review: Abstain
>
> You're showing a part of the v6 branch, for which the ABF isn't ready yet. In v5 it "just works", without pressing virtual buttons. In V5 the definitions are alike, but the code in the trigger does not handle more than two currencies. Also, the button_dummy is missing in the code, leading to redisplay behavior instead of a hard coded write (which leads to nothing, as balance_end isn't stored anywhere).
>
> I'll park this until I'm there.

Sorry, maybe I proposed the wrong branch. This defiantly is needed in 
the upgrade-6.0 branch.

I will redo the tests on 5.0. But as far as I remember it was still needed.


-- 
With best regards,


Dmitrijs Ledkovs

credativ ltd                     Tel: 01788 298152
36 Regent Street                 Fax: 01788 298159
Rugby CV21 2PS - UK              http://www.credativ.co.uk

credativ Ltd is registered in England & Wales, company no. 5261743
Registered office: Nelson House, 2 Hamilton Terrace, Leamington Spa,
Warwickshire CV32 4LY

Certified by AccredIT UK with the ICT Supply standard of quality for
Software Product Design and Development

https://code.launchpad.net/~credativ/account-banking/trunk-refresh/+merge/81761
Your team credativ is subscribed to branch lp:~credativ/account-banking/trunk-refresh.


References