← Back to team overview

credativ team mailing list archive

Re: [Merge] lp:~credativ/openobject-server/fix-yaml-import into lp:openobject-server

 

Review: Approve (idea)

Hi Dmitrijs,

Thanks for the nice and clean merge proposal!

I approve the idea, but as xrg did in his own version of the patch, we have a tradition of considering "False" as NULL for m2o fields (legacy due to XML-RPC serialization).

If you don't mind I will merge your branch but return False instead of None, as well as support setting the YAML field to False too, as it seems to me they both carry the same meaning for a m2o field.

Thanks!
-- 
https://code.launchpad.net/~credativ/openobject-server/fix-yaml-import/+merge/79375
Your team credativ is subscribed to branch lp:~credativ/openobject-server/fix-yaml-import.


Follow ups

References