← Back to team overview

credativ team mailing list archive

[Bug 876200] Re: [base_vat] Basic VAT check when country specific check not defined in the module

 

Hi all.

I particularly agree with comment #4: vat checking is a nice plus, but
customers must be able to enter any VAT code, even from an unsupported
country.

There are many better approaches to to this check, like the xrg one, or
the one in 6.1 (not tested yet). Still, the general idea should be that
the module tries to check what it can, and only give an error when it
knows that the number is incorrect.

A quick fix for v6 is just to "return True" instead of "return False"
when we have an unknown country. I think we can get that in, since my
customer has a service contract ) . General improvements can still go to
6.1.

Thanks!

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/876200

Title:
  [base_vat] Basic VAT check when country specific check not defined in
  the module

Status in OpenERP Addons (modules):
  Won't Fix

Bug description:
  The module base_vat does not consider all VAT countries worldwide.

  In case that a country specific validation is not defined in the
  base_vat module, only a basic country check should be performed, but
  otherwise should allow the VAT code to be introduced.

  The basic check should be as per
  http://en.wikipedia.org/wiki/VAT_identification_number#VAT_numbers_by_countries:

  The full identifier starts with an ISO 3166-1 alpha-2 country code
  (except for Greece which uses the non-standard country code EL) and
  then has between 5 and 12 characters. These 5 to 12 characters are
  numeric in most countries but in some countries they may contain
  letters.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/876200/+subscriptions