← Back to team overview

credativ team mailing list archive

[Bug 909124] Re: [trunk] new module account_bank_statement_extension conflicts with point_of_sale

 

sorry but i disagree here: if the field duplicated has to be changed
somewhere it is in point_of_sale where the naming doesn't reflect the
type of the field. Rename it into journal_name.

We shouldn't go the code creepy for the sake of "easing the migrations".

Another (a best) solution is to add this field (related, many2one)  in
account module in order to avoid totally .duplicated fields

** Changed in: openobject-addons
       Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/909124

Title:
  [trunk] new module account_bank_statement_extension conflicts with
  point_of_sale

Status in OpenERP Addons (modules):
  In Progress

Bug description:
  The new module account_bank_statement_extensions coming from Noviat
  merge proposal is conflicting with the pre-existing point_of_sale
  module.

  It redefining the column journal_id in the model account.bank.statement.line with a different type
  account_bank_statement_extensions:
   'journal_id': fields.related('statement_id', 'journal_id', type='many2one',...)
  point_of_sale:
  'journal_id': fields.related('statement_id','journal_id','name', store=True, string='Journal', type='char', size=64),

  Please rename that column in the account_bank_statement_extensions
  (and not in point_of_sale to ease migration)

  kr
  J-E

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/909124/+subscriptions


References