credativ team mailing list archive

["Olivier Dony \(OpenERP\)" <922621@xxxxxxxxxxxxxxxxxx>]

Hi,

The 'foreign_balance' function field represents the balance in the secondary currency for GL accounts which *do have* a secondary currency set (currency_id != False), and thus have all their journal items expressed in that same secondary currency.
It makes no sense for GL accounts which have no secondary currency, and thus may mix different currencies.

We should improve the __compute function to make sure the foreign_balance is always computed as 0 for GL accounts that don't have a secondary currency.
This may confuse other people tinkering with the low-level accounting database structure, so let's not consider this a Wishlist.

Thanks for reporting.

** Changed in: openobject-addons
   Importance: Undecided => Low

** Changed in: openobject-addons
       Status: New => Confirmed

** Changed in: openobject-addons
    Milestone: None => 6.1

** Changed in: openobject-addons
     Assignee: (unassigned) => OpenERP R&D Addons Team 3 (openerp-dev-addons3)

** Summary changed:

- [trunk] bad computation for multicurrency move lines
+ [trunk] foreign_balance should not be computed for account with no secondary currency

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/922621

Title:
  [trunk] foreign_balance should not be computed for account with no
  secondary currency

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Hello.

  We are working on this Optimization:

  https://code.launchpad.net/~vauxoo/openobject-addons/trunk-bug_887376
  -account_compute_with_btree-VAUXOO/+merge/89741

  And we face a BIG problem with multicurrency feature just improved
  some little time ago.

  In this line of account.py

  'foreign_balance': "COALESCE(SUM(l.amount_currency), 0) as
  foreign_balance",

  We see that this algorithm sum all multicurrency values and it is
  TOTALLY wrong, because i can have n the same account different vaules,
  and we NEVER can sum Apples with Pears.

  How functionally you can try:

  Make an move invoice on €.
  Then Make an invoice to same partner in USD$
  Make an invoice an you currency, (We Use VEF).

  Then go to edit tree view for accounts and show the field
  "foreign_balance" with the view editor,

  You can face that if pfor example you made 3 invoice for 100 CURRENCY,
  the total for the account REceivable or Payable related on this
  invoices.

  The amount received is 300 (sum directly for 100€ 100$ and 100VEF)

  -In V6 this feature is simply missing.-

  I think it is a huge cancept mistake.

  IMHO, we need to have from OpenERP-dev team a Blueprint related with
  the concept that they want to implement in this field, because in
  other way this field is really useless and affect the performance in
  calculation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/922621/+subscriptions