credativ team mailing list archive

["Stefan Rijnhart \(Therp\)" <953468@xxxxxxxxxxxxxxxxxx>]

If a column does not exist, then maybe the whole pre or post script
should not run at all and this should be tested before the scripts make
any modification. So I am in favour of such checks, but I believe that
all checks should raise fatal errors and halt the upgrade process.

What do you think?



** Changed in: openupgrade-server
       Status: New => Confirmed

** Changed in: openupgrade-server
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of
OpenUpgrade Committers, which is the registrant for OpenUpgrade Server.
https://bugs.launchpad.net/bugs/953468

Title:
  rename_columns should have extra checks

Status in OpenUpgrade Server:
  Confirmed

Bug description:
  - check that table_exists
  - check that target column does not exist
  - check that source column exist

  and return:
   True if the rename is actually performed
   False otherwise

  Maybe some added verbose logging.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openupgrade-server/+bug/953468/+subscriptions