credativ team mailing list archive

[Don Kirkby <donkirkby+launpd@xxxxxxxxx>]

Don Kirkby has proposed merging lp:~zaber/openupgrade-server/rename-index into lp:openupgrade-server/6.0.

Requested reviews:
  OpenUpgrade Committers (openupgrade-committers)
Related bugs:
  Bug #1023173 in OpenUpgrade Server: "Renaming column creates duplicate index"
  https://bugs.launchpad.net/openupgrade-server/+bug/1023173

For more details, see:
https://code.launchpad.net/~zaber/openupgrade-server/rename-index/+merge/114285

Fix bug 1023173 by dropping the index during a column rename.
-- 
https://code.launchpad.net/~zaber/openupgrade-server/rename-index/+merge/114285
Your team OpenUpgrade Committers is requested to review the proposed merge of lp:~zaber/openupgrade-server/rename-index into lp:openupgrade-server/6.0.

=== modified file 'bin/openupgrade/openupgrade.py'
--- bin/openupgrade/openupgrade.py	2012-06-23 14:23:36 +0000
+++ bin/openupgrade/openupgrade.py	2012-07-10 22:03:19 +0000
@@ -105,6 +105,7 @@
             logger.info("table %s, column %s: renaming to %s",
                      table, old, new)
             cr.execute('ALTER TABLE "%s" RENAME "%s" TO "%s"' % (table, old, new,))
+            cr.execute('DROP INDEX IF EXISTS "%s_%s_index"' % (table, old))
 
 def rename_tables(cr, table_spec):
     """