← Back to team overview

credativ team mailing list archive

Re: [Merge] lp:~pedro.baeza/openupgrade-addons/6.1-fetchmail into lp:openupgrade-addons/6.1

 

Review: Needs Fixing

Hi Pedro,

this proposal is set to 'Work in progress', which is why it did not get reviewed earlier on. Does it need any more work as far as you are concerned?

>From my part, please use the @migrate decorator to replace the try/catch block, the logging part and the version check. And Paulius' suggestion looks good to me too.



-- 
https://code.launchpad.net/~pedro.baeza/openupgrade-addons/6.1-fetchmail/+merge/133469
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons/6.1.


References