← Back to team overview

credativ team mailing list archive

Re: [Merge] lp:~sylvain-legal/openupgrade-addons/migration-product into lp:openupgrade-addons

 

Review: Approve code review

Yes, the comments in the analysis file are very helpful. Let's do this in all future migrations.

One small thing: You don't need to declare {post,pre}-migration.py if there's nothing to do, but the way you did it it's fine of course
-- 
https://code.launchpad.net/~sylvain-legal/openupgrade-addons/migration-product/+merge/174434
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.


References