credativ team mailing list archive

Thread
Date

Re: [Merge] lp:~pedro.baeza/openupgrade-addons/6.1-fetchmail into lp:openupgrade-addons/6.1

To: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Thu, 18 Jul 2013 10:13:01 -0000
In-reply-to: <20130718093219.21427.82358.codereview@soybean.canonical.com>
Reply-to: mp+133469@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Thank you Pedro! To finish it off, you can remove the now unsed imports of os, logging and osv from the file. l.31 is now unused too, and I would appreciate if you could break up lines 9 and 48 to respect PEP max. line length.

-- 
https://code.launchpad.net/~pedro.baeza/openupgrade-addons/6.1-fetchmail/+merge/133469
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons/6.1.

References

Re: [Merge] lp:~pedro.baeza/openupgrade-addons/6.1-fetchmail into lp:openupgrade-addons/6.1
From: Pedro Manuel Baeza, 2013-07-18