credativ team mailing list archive

Thread
Date

Re: lp:~therp-nl/openupgrade-server/three-functions-for-addons-migration into lp:openupgrade-server

To: mp+175790@xxxxxxxxxxxxxxxxxx
From: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
Date: Mon, 22 Jul 2013 06:11:01 -0000
In-reply-to: <20130719101732.26327.14435.launchpad@ackee.canonical.com>
Reply-to: mp+175790@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I think message() needs the keyword arguments table = None and column = None to be able to present more fine-grained messages to the administrator. Also a severity = logging.WARNING would be great in my opinion.

In 38ff and 46ff, I propose to correct the typo and some grammatical weaknesses.
-- 
https://code.launchpad.net/~therp-nl/openupgrade-server/three-functions-for-addons-migration/+merge/175790
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-server.

References

lp:~therp-nl/openupgrade-server/three-functions-for-addons-migration into lp:openupgrade-server
From: Stefan Rijnhart (Therp), 2013-07-19