credativ team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/openupgrade-server/7.0-allow_view_breakage into lp:openupgrade-server.

Requested reviews:
  OpenUpgrade Committers (openupgrade-committers)
Related bugs:
  Bug #1200888 in OpenUpgrade Server: "Bug migrating 'mail' module due to a view associated to 'base' module. ('base.view_crm_partner_info_History')"
  https://bugs.launchpad.net/openupgrade-server/+bug/1200888

For more details, see:
https://code.launchpad.net/~therp-nl/openupgrade-server/7.0-allow_view_breakage/+merge/176666
-- 
https://code.launchpad.net/~therp-nl/openupgrade-server/7.0-allow_view_breakage/+merge/176666
Your team OpenUpgrade Committers is requested to review the proposed merge of lp:~therp-nl/openupgrade-server/7.0-allow_view_breakage into lp:openupgrade-server.

=== modified file 'openerp/addons/base/ir/ir_ui_view.py'
--- openerp/addons/base/ir/ir_ui_view.py	2013-04-15 10:57:44 +0000
+++ openerp/addons/base/ir/ir_ui_view.py	2013-07-24 12:14:35 +0000
@@ -126,8 +126,9 @@
             fvg = self.pool.get(view.model).fields_view_get(cr, uid, view_id=view.id, view_type=view.type, context=context)
             return fvg['arch']
         except:
-            _logger.exception("Can't render view %s for model: %s", view.xml_id, view.model)
-            return False
+            # OpenUpgrade: do not break on unrenderable views
+            _logger.warn("Can't render view %s for model: %s", view.xml_id, view.model)
+            return "<data/>"
 
     def _check_xml(self, cr, uid, ids, context=None):
         for view in self.browse(cr, uid, ids, context):