credativ team mailing list archive

Thread
Date

Re: lp:~savoirfairelinux-openerp/openupgrade-server/base_contact into lp:openupgrade-server

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Thu, 14 Nov 2013 20:59:06 -0000
In-reply-to: <20131111224124.2442.69791.launchpad@ackee.canonical.com>
Reply-to: mp+194762@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Thanks for adapting the check for base_contact!

I see now how the mobile field can go AWOL. Base_contact changes the field type to an unstored related field, upon which the ORM drops the column (I never liked it doing that). So your code makes good sense.

I'd like it though, if you could report on the missing fields in a logged warning. Would you mind doing so? Apart from that, this looks really good.


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openupgrade-server/base_contact/+merge/194762
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-server.

References

[Merge] lp:~savoirfairelinux-openerp/openupgrade-server/base_contact into lp:openupgrade-server
From: Sandy Carter (http://www.savoirfairelinux.com), 2013-11-11