credativ team mailing list archive

Thread
Date

Re: lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password into lp:openupgrade-server

To: "Ronald Portier \(Therp\)" <ronald@xxxxxxxx>
From: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
Date: Mon, 06 Jan 2014 12:34:44 -0000
In-reply-to: <20140102130726.8924.92979.launchpad@ackee.canonical.com>
Reply-to: mp+200301@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

10ff: You need to check if this option exists (has_option) before accessing it, as also SafeConfigParser raises ConfigParser.NoOptionError on nonexisting options. Then you can remove 12f

Could you explain why you do the extra checks and unset PGPASSWORD? The environment you change will die with the script process, and the only other processes who see it are the openupgrade servers it starts, or am I mistaken?
-- 
https://code.launchpad.net/~therp-nl/openupgrade-server/7.0_lp1265463_use_password/+merge/200301
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-server.

References

[Merge] lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password into lp:openupgrade-server
From: Ronald Portier (Therp), 2014-01-02