credativ team mailing list archive

["Craig Gowing \(credativ\)" <craiggowing@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Hi Matt,

Thanks for the merge request. Just have a few points about some of the changes since this is a public module and there are a few Made specific changes:
* For the new field 'orium_report' on the user, could this be made more general so something like 'wms_report'?
* There are a lot of references to Orium and Made in the code, could these be made more generic. Changes where fields should be more specific to Made or Orium could be made in the private modules.
* The email address in the function is hardcoded to 'erp@xxxxxxxx'. Instead would it be possible to use a mail template for the email which could be modified outside of the code, for example different email recipients, subject etc. Alternately these specific changes could be made in the private module.

Thanks,
Craig


-- 
https://code.launchpad.net/~matthieuchoplin/credativ-openerp/ERP-449/+merge/202729
Your team credativ is subscribed to branch lp:credativ-openerp.