credativ team mailing list archive

Thread
Date

Re: [Merge] lp:~openupgrade-committers/openupgrade-addons/7.0-account_analytic_plans-pedro.baeza into lp:openupgrade-addons

To: mp+210213@xxxxxxxxxxxxxxxxxx
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Mon, 10 Mar 2014 14:41:06 -0000
In-reply-to: <20140310142921.31754.21564.launchpad@ackee.canonical.com>
Reply-to: mp+210213@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Thanks Pedro!

I'm looking at the code and I see that the plan_id was required in the form already in 6.1. Lines could however end up without a plan_id if the plan was deleted. This solution is as good as any. Maybe jot down a note in user_notes.txt that any dangling lines will be linked to a specially created plan by the name of 'OpenUpgrade migration plan'?

-- 
https://code.launchpad.net/~openupgrade-committers/openupgrade-addons/7.0-account_analytic_plans-pedro.baeza/+merge/210213
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.

References

[Merge] lp:~openupgrade-committers/openupgrade-addons/7.0-account_analytic_plans-pedro.baeza into lp:openupgrade-addons
From: Stefan Rijnhart (Therp), 2014-03-10