← Back to team overview

credativ team mailing list archive

Thread
Date

Re: [Merge] lp:~credativ/ocb-addons/7.0-rounding-fix-average-price into lp:ocb-addons

To: "Jacob Hicks \(credativ\)" <jacob.hicks@xxxxxxxxxxxxxx>
From: Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>
Date: Fri, 28 Mar 2014 10:38:12 -0000
In-reply-to: <20140321165821.14517.67938.launchpad@ackee.canonical.com>
Reply-to: mp+212195@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

You're changing the API - you're doing it cleanly so it shouldn't break, but it may be easier to push upstream if you used the context instead, if it makes sense of course.
-- 
https://code.launchpad.net/~credativ/ocb-addons/7.0-rounding-fix-average-price/+merge/212195
Your team credativ is subscribed to branch lp:~credativ/ocb-addons/7.0-rounding-fix-average-price.

References

[Merge] lp:~credativ/ocb-addons/7.0-rounding-fix-average-price into lp:ocb-addons
From: Jacob Hicks (credativ), 2014-03-21