credativ team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/openupgrade-addons/fix-lp1325530 into lp:openupgrade-addons.

Requested reviews:
  OpenUpgrade Committers (openupgrade-committers)
Related bugs:
  Bug #1325530 in OpenUpgrade Addons: ""Invalid syntax" error in ./addons/account_analytic_plans/migrations/7.0.1.0/pre-migration.py"
  https://bugs.launchpad.net/openupgrade-addons/+bug/1325530

For more details, see:
https://code.launchpad.net/~pedro.baeza/openupgrade-addons/fix-lp1325530/+merge/221727

[FIX] account_analytic_plans: Corrected brackets for logged_query calls.
-- 
https://code.launchpad.net/~pedro.baeza/openupgrade-addons/fix-lp1325530/+merge/221727
Your team OpenUpgrade Committers is requested to review the proposed merge of lp:~pedro.baeza/openupgrade-addons/fix-lp1325530 into lp:openupgrade-addons.

=== modified file 'account_analytic_plans/migrations/7.0.1.0/pre-migration.py'
--- account_analytic_plans/migrations/7.0.1.0/pre-migration.py	2014-03-01 09:09:16 +0000
+++ account_analytic_plans/migrations/7.0.1.0/pre-migration.py	2014-06-02 13:07:07 +0000
@@ -34,11 +34,11 @@
         logged_query(cr, ("""
             INSERT INTO account_analytic_plan ('name')
             FROM account_analytic_plan_line
-            VALUES ('OpenUpgrade migration plan')""")
+            VALUES ('OpenUpgrade migration plan')"""))
         # Fill empty values with this new record value
         logged_query(cr, ("""
             UPDATE account_analytic_plan_line
             SET plan_id = 
                 (SELECT id FROM account_analytic_plan 
                  WHERE NAME='OpenUpgrade migration plan')
-            WHERE plan_id is NULL""")
+            WHERE plan_id is NULL"""))