← Back to team overview

cuneiform team mailing list archive

Re: Patch to build in MSVC++ (MSK export definitions)

 

 This i not a bug in MinGW. In this patch (see attach) I try to fix problems
with wrong redefinitions of  'cdecl', but I can't check it in xNix.

2009/1/24 Dmitry Polevoy <openocr.polevoy@xxxxxxxxx>

> It looks like a problem with \include\decl.h. In leo_dll.c it includes
> BEFORE globus.h throw cpu.h
>
> You can use this patch to check my opinion
>
> === modified file 'cuneiform_src/Kern/leo/src/
> leo_dll.c'
> --- cuneiform_src/Kern/leo/src/leo_dll.c    2009-01-21 14:52:06 +0000
> +++ cuneiform_src/Kern/leo/src/leo_dll.c    2009-01-24 07:36:26 +0000
> @@ -61,10 +61,11 @@
>  /*#include <io.h>*/
>
>  #include "leo_tune.h"
> +#include "leo.h"
> +
>  #include "cpu.h"
>  #define PC_TYPE 0
>  #define MAX_FIELDS 1000
> -#include "leo.h"
>  #include "alphaset.h"
>  #include "leo_func.h"
>
> Change include order helps to build libraries, but it's not a right patch -
> it is only a diagnostic. For example, after my first patch I have to make
> the following patch and so on...
>
> === modified file 'cuneiform_src/Kern/rline/sources/newline.cpp'
> --- cuneiform_src/Kern/rline/sources/newline.cpp    2008-09-15 14:00:40
> +0000
> +++ cuneiform_src/Kern/rline/sources/newline.cpp    2009-01-24 07:49:16
> +0000
> @@ -63,13 +63,14 @@
>  #include <cstring>
>  #include <time.h>
>
> +#include "rline.h"
> +
>  #include "stdafx.h"
>  #include "linedefs.h"
>  #include "lnsdefs.h"
>  #include "cpage.h"
>  #include "ctiimage.h"
>  #include "rshelllinescom.h"
> -#include "rline.h"
>  #include "dpuma.h"
>  #include "cline.h"
>  #include "ccom.h"
>
>
>
> 2009/1/23 Jussi Pakkanen <jpakkane@xxxxxxxxx>
>
> On Wed, Jan 21, 2009 at 7:38 PM, Dmitry Polevoy
>> <openocr.polevoy@xxxxxxxxx> wrote:
>>
>> > In attach is a variant of you visibility patch (Bug 260809) working in
>> > MinGW. I hope it helps you.
>>
>> I get the same error as with my patch:
>>
>> Linking C shared library ..\..\..\librstr.dll
>> CMakeFiles\rstr.dir\src\alphabet.c.obj: In function
>> `save_alphabet_information':
>> C:/Documents and
>>
>> Settings/veijo/workspace/cuneiform/cuneiform_src/Kern/rstr/src/alphabet.c:696:
>> undefined reference to `__imp__LEOSetupField'
>>
>> The definitions are the same as other subdirectories so it should work.
>>
>> I use MinGW 4.3 prerelease version. If it works for you, maybe this is
>> a bug in MinGW?
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~cuneiform<https://launchpad.net/%7Ecuneiform>
>> Post to     : cuneiform@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~cuneiform<https://launchpad.net/%7Ecuneiform>
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>

Attachment: 20090125.patch
Description: Binary data


Follow ups

References