← Back to team overview

cuneiform team mailing list archive

[Bug 640038] Re: i386 assembly

 

Sorry for late reply.
The currently commited fix doesn't work, unforunately. I attach a patch with necessary corrections.

** Patch added: "swapbytes2.diff"
   https://bugs.launchpad.net/cuneiform-linux/+bug/640038/+attachment/1675323/+files/swapbytes2.diff

-- 
i386 assembly
https://bugs.launchpad.net/bugs/640038
You received this bug notification because you are a member of Cuneiform
Linux, which is the registrant for Cuneiform for Linux.

Status in Linux port of Cuneiform: Fix Committed

Bug description:
In Kern/rstr/src/perc.c, there is some i386 assembly code used to swap byte order. This is ugly and unportable.
In Debian this issue was fixed by applying the attached patch; however it is not very portable either, as it requires a relatively recent version of GNU libc.
Perhaps the most portable way to fix it is to use the htonl() function: http://opengroup.org/onlinepubs/007908775/xns/htonl.html





References