curtin-dev team mailing list archive

[Ryan Harper <ryan.harper@xxxxxxxxxxxxx>]

There's a completely different error on power now... on focal (Un related to this change too!)

Diff comments:

> diff --git a/tests/vmtests/test_basic.py b/tests/vmtests/test_basic.py
> index bb6d3a4..b442d8b 100644
> --- a/tests/vmtests/test_basic.py
> +++ b/tests/vmtests/test_basic.py
> @@ -132,7 +132,11 @@ class TestBasicAbs(VMBaseClass):
>  
>      def test_partition_numbers(self):
>          # pnum_disk should have partitions 1 2, and 10
> -        disk = self._dname_to_kname('pnum_disk')
> +        if self.target_release != 'centos66':
> +            disk = self._dname_to_kname('pnum_disk')
> +        else:
> +            disk = self._serial_to_kname('disk-d')

I don't think so; but we can add some words here.  This path is only taken on x86, centos images are amd64 only; so the "unstable" arches where scsi moves around (ppc64le and arm64)
won't run the non-dname path.

> +
>          expected = [disk + s for s in ["", "1", "2", "10"]]
>          self._test_partition_numbers(disk, expected)
>  


-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382704
Your team curtin developers is requested to review the proposed merge of ~raharper/curtin:fix/vmtest-centos-basic into curtin:master.