← Back to team overview

curtin-dev team mailing list archive

[Merge] ~raharper/curtin:fix/udevadm-info-shlex-quote into curtin:master

 

The proposal to merge ~raharper/curtin:fix/udevadm-info-shlex-quote into curtin:master has been updated.

Commit message changed to:

udev: use shlex.quote when shlex.split errors on shell-escape chars

The udev database may include shell escape characters in the output.
We want to avoid using shlex_quote unless needed as curtin does not
use the quoted value in our code and applying it to all of the values
breaks parsing of the udevadm info content.

If we encounter a ValueError while invoking shlex.split() then we
first use shlex_quote() and try parsing again and if that fails we
will try replacing shell-quote values with '_'. We log warning
whenever we have to quote or replace values.

- Python2.7 shlex does not implement quote, use a best approximation
- Add unittest with original info dump from bug submitters system

LP: #1875085

For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382993
-- 
Your team curtin developers is subscribed to branch curtin:master.


References