curtin-dev team mailing list archive

[Ryan Harper <ryan.harper@xxxxxxxxxxxxx>]

Review: Needs Fixing

Thanks for the Merge Proposal (MP).  I failed to bring up how we land changes, so this is my fault.

1) Please move your Description into the 'Set Commit Message' box;  the autolander here won't use the description and complains when it's set at landing time.

2) The format for the commit message is:

oneliner

Longer description here with details on what
changed.  Including addition changes in the merge

 - I also updated the .gitignore file

LP: #NNNNNNN   if this was fixing a bug





Diff comments:

> diff --git a/.gitignore b/.gitignore
> index 8f343e7..27bc062 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -3,3 +3,4 @@ __pycache__
>  .tox
>  .coverage
>  curtin.egg-info/
> +.idea

This is an unrelated change to the MR, can you remove this and propose it separately?  Thanks



-- 
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
Your team curtin developers is subscribed to branch curtin:master.