curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~lamoura/curtin:disable-networking-config into curtin:master

To: mp+383785@xxxxxxxxxxxxxxxxxx
From: Lucas Albuquerque Medeiros de Moura <lucas.moura@xxxxxxxxxxxxx>
Date: Wed, 13 May 2020 18:55:06 -0000
In-reply-to: <158929226226.9506.4581630746393658786.launchpad@ackee.canonical.com>
Reply-to: mp+383785@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

raharper I have addressed the changes you commented. I have created the disabled option on the net_meta module and created a VMTest for this command.

I have also created two new VMTests for the {"config": "disabled"} possibility as well. For the case of a network disabled config without a version, I had to change some parts of the code that were getting the version key from the config dict. But if you think I can do that differently, no problem.

Also, I have only added Focal tests, but if my solution is correct I can add more instance types as well.
-- 
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.

References

[Merge] ~lamoura/curtin:disable-networking-config into curtin:master
From: Lucas Albuquerque Medeiros de Moura, 2020-05-12