curtin-dev team mailing list archive

[Dan Watkins <daniel.watkins@xxxxxxxxxxxxx>]

Review: Approve

LGTM, thanks!

Diff comments:

> diff --git a/tests/unittests/test_commands_install_grub.py b/tests/unittests/test_commands_install_grub.py
> index 1d0c43f..8808159 100644
> --- a/tests/unittests/test_commands_install_grub.py
> +++ b/tests/unittests/test_commands_install_grub.py
> @@ -201,6 +201,15 @@ class TestGetCarryoverParams(CiTestCase):
>          self.assertEqual(expected_carry_params,
>                           install_grub.get_carryover_params(distroinfo))
>  
> +    def test_multiple_preferred_separator(self):
> +        distroinfo = install_grub.distro.get_distroinfo()
> +        sep = '---'
> +        expected_carry_params = ['extra', 'additional']
> +        cmdline = "lead=args %s extra %s additional" % (sep, sep)

A nit, but `"lead=args {0} extra {0} additional".format(sep)` would save the repetition of `sep`.

> +        self.m_load_file.return_value = cmdline
> +        self.assertEqual(expected_carry_params,
> +                         install_grub.get_carryover_params(distroinfo))
> +
>      def test_drop_bootif_initrd_boot_image_from_extra(self):
>          distroinfo = install_grub.distro.get_distroinfo()
>          sep = '---'


-- 
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384469
Your team curtin developers is subscribed to branch curtin:master.