curtin-dev team mailing list archive

[Paride Legovini <paride.legovini@xxxxxxxxxxxxx>]

Paride Legovini has proposed merging ~legovini/curtin:curtainer-mask-zfs-services into curtin:master.

Commit message:
curtainer: mask the zfs-mount and zfs-share services
    
curtin depends on zfsutils-linux via probert-storage, but zfsutils-linux
can't be installed in an unprivileged container as it fails to start the
zfs-mount and zfs-share services as /dev/zfs is missing. We do not
actually need ZFS to work in the container, so the problem can be worked
around by masking the services before the package is installed.


Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/385820
-- 
Your team curtin developers is requested to review the proposed merge of ~legovini/curtin:curtainer-mask-zfs-services into curtin:master.

diff --git a/tools/curtainer b/tools/curtainer
index 466d719..34ccfb6 100755
--- a/tools/curtainer
+++ b/tools/curtainer
@@ -161,6 +161,14 @@ main() {
 
     inside "$name" which eatmydata >/dev/null || eatmydata=""
 
+    # curtin depends on zfsutils-linux via probert-storage, but zfsutils-linux
+    # can't be installed in an unprivileged container as it fails to start
+    # the zfs-mount and zfs-share services as /dev/zfs is missing. We do
+    # not actually need ZFS to work in the container, so the problem can be
+    # worked around by masking the services before the package is installed.
+    inside "$name" systemctl mask zfs-mount
+    inside "$name" systemctl mask zfs-share
+
     if $proposed; then
         mirror=$(inside $name awk '$1 == "deb" { print $2; exit(0); }' \
             /etc/apt/sources.list) &&